Feature IDs implementation for credentials#6415
Merged
S-Saranya1 merged 4 commits intofeature/master/feature-ids-implementationfrom Sep 16, 2025
Merged
Conversation
…mentation' into somepal/Credentials-featureID-implementation
|
Fred1155
reviewed
Sep 12, 2025
| assertThat(userAgentHeaders.get(0)).contains(expected); | ||
| } | ||
|
|
||
| private static Stream<Arguments> systemPropertyCredentialProvidersWithSessionToken() { |
Contributor
There was a problem hiding this comment.
I noticed that for all test it is written as ParameterizedTest, however there's only one parameter in the method source. Do we have a reason for why we are setting it as the ParameterizedTest?
Fred1155
approved these changes
Sep 12, 2025
S-Saranya1
merged commit 8141a30
into
feature/master/feature-ids-implementation
29 of 30 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds business metric tracking for credentials
Motivation and Context
Keeping track of how users are providing credentials to SDKs and which credentials providers are being used.
Modifications
This PR adds business metrics support for these credential providers:
CREDENTIALS_HTTP(
z) - ContainerCredentialsProviderCREDENTIALS_ENV_VARS(
g) - EnvironmentVariableCredentialsProviderCREDENTIALS_IMDS (
0) - InstanceProfileCredentialsProviderCREDENTIALS_PROCESS(
w) - ProcessCredentialsProviderCREDENTIALS_CODE(
e) - Base credentials identifierCREDENTIALS_JVM_SYSTEM_PROPERTIES (
f) - SystemPropertyCredentialsProviderCREDENTIALS_ENV_VARS_STS_WEB_ID_TOKEN(
h) - WebIdentityTokenFileCredentialsProviderChanges made:
cfg/auth-source, deprecated it and added to them/business metrics string insteadTesting
Added unit tests for all those credentials.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License